This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngRoute): pipe preceding route param no longer masks ? or * operator #5920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change,
```js
$routeProvider.when('/foo/:bar|?', { ... });
```
would not have the expected effect --- the parameter would not be optional, and
the pipe would not be included in the parameter name.
Following this change, the presence of the pipe operator will typically cause an
exception to be thrown due to the fact that the generated regexp is invalid.
The net result of this change is that ? and * operators will not be masked, and
pipe operators will need to be removed, although it's unexpected that these are
being used anywhere.
|
Should this be tagged as a breaking change? |
|
@lrlopez I mentioned that on the dev hangout, but the truth is I am highly skeptical that anybody is actually affected by this change, people don't tend to use pipes in their param names, I don't think. So the truth is, although this is a bug, it's probably not affecting anybody. |
|
Thanks for the explanation. |
|
? and * are also affected by another bug with redirects, see #5746 |
|
lgtm please merge. |
ghost
assigned 
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change,
would not have the expected effect --- the parameter would not be optional, and the pipe would not be included in the parameter name.
Following this change, the presence of the pipe operator will typically cause an exception to be thrown due to the fact that the generated regexp is invalid.
The net result of this change is that ? and * operators will not be masked, and pipe operators will need to be removed, although it's unexpected that these are being used anywhere.